[
https://issues.apache.org/jira/browse/CASSANDRA-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085827#comment-17085827
]
Jon Meredith commented on CASSANDRA-15709:
------------------------------------------
I think it's good to merge, as long as you're happy with it and a +1 from a
non-committer is acceptable.
It just needs these two commits merged (fixup on the second) and the commit
message updated to record David as the reviewer and you as the merger.
04e45f97377026b92fc42c2dc85633d1c54eac67
596e924a35e5513d9b8e72329f4a897c9631bcb9
I'm happy to do the squash/fixup comments and force-push up to the review
branch if you'd like
> SEPExecutorTest changingMaxWorkersMeetsConcurrencyGoalsTest failure
> -------------------------------------------------------------------
>
> Key: CASSANDRA-15709
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15709
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Marcus Eriksson
> Assignee: Jon Meredith
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code}
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> [junit-timeout] Testsuite: org.apache.cassandra.concurrent.SEPExecutorTest
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.656 sec
> [junit-timeout]
> [junit-timeout] Testcase:
> changingMaxWorkersMeetsConcurrencyGoalsTest(org.apache.cassandra.concurrent.SEPExecutorTest):
> FAILED
> [junit-timeout] expected:<true> but was:<false>
> [junit-timeout] junit.framework.AssertionFailedError: expected:<true> but
> was:<false>
> [junit-timeout] at
> org.apache.cassandra.concurrent.SEPExecutorTest.assertMaxTaskConcurrency(SEPExecutorTest.java:180)
> [junit-timeout] at
> org.apache.cassandra.concurrent.SEPExecutorTest.changingMaxWorkersMeetsConcurrencyGoalsTest(SEPExecutorTest.java:110)
> [junit-timeout]
> [junit-timeout]
> [junit-timeout] Test org.apache.cassandra.concurrent.SEPExecutorTest FAILED
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
