[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089156#comment-17089156
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-------------------------------------------------
@David, thanks for the review and the clarifications and Slack constructive
discussion!
So looks like we have the same vision and I missed one thing. Let me wrap up
here for the record and [~mck] who is also looking into it.
Part2 - null is a legit issue and no one of us likes the idea of adding "" in
the yaml file. Still have to spend time to think about a workaround and that
we already have it there.
The Memory class is kind of what I meant when I said I have to pull the current
implementation separately.
So the suggestion is to pull into three additional classes - Memory, Throughput
and TimeDuration (or something similar)
The confusion was about a thing I saw and forgot to take care. :\
There are 11 getters in the DatabaseDescriptor.
They need to be changed to only getters without doing one more layer of
conversion to bytes. Example:
getMaxValueSizeInBytes() { return maxValue.toBytes(); } -> Memory
getMaxValueSize() { return maxValue}
This will clean the code and make it easy for maintenance.
Part 3 - code-wise not related to Part1 and 2, just additional small task which
was requested in the previous comments, considering we are trying to do
standardization as part of this ticket.
Whether we keep all of them in one class or we split is a matter of agreement I
think. As soon as we get it, I will correct it. This is real quick.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0, 4.0-beta
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
