[ 
https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094720#comment-17094720
 ] 

Yifan Cai commented on CASSANDRASC-22:
--------------------------------------

{quote}The api docs were already generated and committed in source prior to the 
patch, this patch just regenerates them.
{quote}
Jon, I double checked that the generated files, e.g. 
{{[src/main/resources/docs/index.html|https://github.com/dineshjoshi/cassandra-sidecar/commit/037cc67c3bc5c30f2920a2eedde54c0fac3998b7#diff-2a8fd278f0d7b384c76330db29482ba6]}}
 is new in the patch. None of those files exist in the current upstream master. 
So I would like to confirm we are talking about the same files. 

If they are the same files, and as you mentioned "I already have a WIP patch to 
address this", I am cool with addressing it in a separate patch. But still, 
those generated files should not be checked in, if we can avoid it later. 

> RESTEasy integration for Cassandra Sidecar
> ------------------------------------------
>
>                 Key: CASSANDRASC-22
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-22
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Rest API
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Normal
>         Attachments: image-2020-04-27-22-59-40-060.png
>
>
> Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This 
> also dynamically generates swagger documentation and adds the swagger UI.
> [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger]
> [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to