[
https://issues.apache.org/jira/browse/CASSANDRA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093752#comment-17093752
]
Stefan Miklosovic edited comment on CASSANDRA-15158 at 4/28/20, 7:35 PM:
-------------------------------------------------------------------------
Hi [~bdeggleston]
I took the patch and rewored it little bit
[https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15158-2]
Looking forward to have some feedback!
was (Author: stefan.miklosovic):
Hi [~bdeggleston]
I took the patch and rewored it little bit
[https://github.com/smiklosovic/cassandra/commits/CASSANDRA-15158]
You have said that there is not any way how to confirm that any in flight
migration tasks have been completed and applied. I do not know how to verify
this was indeed done but what I did is that I have exposed the information if a
particular migration task has failed or not to process (based on onFailure
callback) so we can work on this further if necessary.
Logically, it is same stuff as it was before in the original patch but the code
is reorganised a bit. The "escape hatch" is one global bootstrap timeout, if it
is passed and schemas are still not in agreement, it is still uknown to me what
we want to do - either fail completely and halt that node or we allow to
proceed with big fat warning.
Looking forward to have some feedback!
> Wait for schema agreement rather then in flight schema requests when
> bootstrapping
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-15158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15158
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip, Cluster/Schema
> Reporter: Vincent White
> Assignee: Ben Bromhead
> Priority: Normal
>
> Currently when a node is bootstrapping we use a set of latches
> (org.apache.cassandra.service.MigrationTask#inflightTasks) to keep track of
> in-flight schema pull requests, and we don't proceed with
> bootstrapping/stream until all the latches are released (or we timeout
> waiting for each one). One issue with this is that if we have a large schema,
> or the retrieval of the schema from the other nodes was unexpectedly slow
> then we have no explicit check in place to ensure we have actually received a
> schema before we proceed.
> While it's possible to increase "migration_task_wait_in_seconds" to force the
> node to wait on each latche longer, there are cases where this doesn't help
> because the callbacks for the schema pull requests have expired off the
> messaging service's callback map
> (org.apache.cassandra.net.MessagingService#callbacks) after
> request_timeout_in_ms (default 10 seconds) before the other nodes were able
> to respond to the new node.
> This patch checks for schema agreement between the bootstrapping node and the
> rest of the live nodes before proceeding with bootstrapping. It also adds a
> check to prevent the new node from flooding existing nodes with simultaneous
> schema pull requests as can happen in large clusters.
> Removing the latch system should also prevent new nodes in large clusters
> getting stuck for extended amounts of time as they wait
> `migration_task_wait_in_seconds` on each of the latches left orphaned by the
> timed out callbacks.
>
> ||3.11||
> |[PoC|https://github.com/apache/cassandra/compare/cassandra-3.11...vincewhite:check_for_schema]|
> |[dtest|https://github.com/apache/cassandra-dtest/compare/master...vincewhite:wait_for_schema_agreement]|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
