[ 
https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095600#comment-17095600
 ] 

Jon Haddad edited comment on CASSANDRASC-22 at 4/29/20, 4:39 PM:
-----------------------------------------------------------------

Using docker is far more problematic within docker images than with machine 
images.  I've gone through this process before with another project, which is 
why I moved us to machine images a few weeks back.

While the builds are quicker right now, I prefer not to lose functionality.  
The main issue with machine images is they start up a little slower, which will 
matter less when we have more tests.

Another point - the race condition you found only surfaced due to machine 
images.  Imo the more testing we have, the better.  If you want to add another 
workflow that runs in the docker container, I'm +1 to that, but I'm -1 on 
removing the one that's already there that helped prevent us from committing a 
bug.


was (Author: rustyrazorblade):
Using docker is far more problematic within docker images than with machine 
images.  I've gone through this process before with another project, which is 
why I moved us to machine images a few weeks back.

While the builds are quicker right now, I prefer not to lose functionality.  
The main issue with machine images is they start up a little slower, which will 
matter less when we have more tests.

Another second point - the race condition you found only surfaced due to 
machine images.  Imo the more testing we have, the better.  If you want to add 
another workflow that runs in the docker container, I'm +1 to that, but I'm -1 
on removing the one that's already there that helped prevent us from committing 
a bug.

> RESTEasy integration for Cassandra Sidecar
> ------------------------------------------
>
>                 Key: CASSANDRASC-22
>                 URL: https://issues.apache.org/jira/browse/CASSANDRASC-22
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Improvement
>          Components: Rest API
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Normal
>         Attachments: image-2020-04-27-22-59-40-060.png, 
> image-2020-04-29-01-14-11-756.png
>
>
> Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This 
> also dynamically generates swagger documentation and adds the swagger UI.
> [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger]
> [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to