[
https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096595#comment-17096595
]
Jordan West commented on CASSANDRA-14781:
-----------------------------------------
Hi [~n.v.harikrishna]. I've picked this back up and am getting it ready to
commit. Thanks for your patience.
I've squashed your branch here:
[https://github.com/jrwest/cassandra/commits/14781-trunk.] I made a few minor
changes along the way (I also re-reviewed since it had been a little bit since
I had read the patch):
* Modified {{CHANGES.txt}}
* Modified {{IMutation#validateSize}} javadoc
* Moved call to {{Keyspace.open}} into the catch block of
{{BlockingReadRepairs#createRepairMutation}}. It was only used if we reached
that block anyways.
* Fixed whitespace formatting in
{{MutationExceededMaxSizeException#prepareMessage}}
I ran a build prior to these changes. The build looked good (better than trunk
actually) and any failures do not seem related:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/4/workflows/e43918eb-40d2-45ad-80c3-dbeaa5ee186b]
I've kicked off a new build with the changes above and with the squash
performed:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/6/workflows/3c3f674e-db89-488a-bbd5-98f04de4fd0d]
> Log message when mutation passed to CommitLog#add(Mutation) is too large is
> not descriptive enough
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints, Local/Commit Log, Messaging/Client
> Reporter: Jordan West
> Assignee: Venkata Harikrishna Nukala
> Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch,
> CASSANDRA-14781_3.11.patch
>
>
> When hitting
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
> the log message produced does not help the operator track down what data is
> being written. At a minimum the keyspace and cfIds involved would be useful
> (and are available) – more detail might not be reasonable to include.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
