[
https://issues.apache.org/jira/browse/CASSANDRA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106065#comment-17106065
]
Vinay Chella commented on CASSANDRA-15748:
------------------------------------------
This patch looks good to me except 1 minor nit and question related to nodetool
command support.
Were the changes for the NodeTool command in `EnableAuditLog.java`
intentionally not included to support the new class and parameter format? If we
are providing the ability to configure custom class with parameters, it is good
to support the same via nodetool as well. If we decide not to support, calling
it out could be a good idea
> Provide ability to configure IAuditLogger
> -----------------------------------------
>
> Key: CASSANDRA-15748
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15748
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently there is a parameterless constructor expected for IAuditLogger
> instances. There is not any way how to "inject" configuration properties from
> cassandra.yaml into these concrete classes. This would be very handy for
> custom IAuditLogger implementations.
>
> PR: [https://github.com/apache/cassandra/pull/555]
> [|https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15748]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
