[
https://issues.apache.org/jira/browse/CASSANDRA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106097#comment-17106097
]
Stefan Miklosovic edited comment on CASSANDRA-15748 at 5/13/20, 8:31 AM:
-------------------------------------------------------------------------
[~vinaykumarcse]
yes, this was done on purpose, I think I had this discussion with Marcus
privately, the thing is that I dont know how to propagate map<string, string>
from nodetool's enableauditlogging - there is not any way to pass map from the
command line (at least the straightforward one). If you look closely into
StorageServiceMBean, that patch contains another enableAuditLog method which
can accept a map. It is there for cases somebody really wants to pass some
parameters via map there via JMX. There is as well the original method without
that map, because in tooling like JConsole, that method is not invokable
anymore if it contains a map, so there is not any way to invoke it via JMX,
hence the original method is left there for this purpose.
[~marcuse] also raised an interesting issue that it feels overall "slightly
wrong" to have this enable / disable method there at all. One could just
disable logging, do something bad and enable it again. Hence the question is if
that nodetool command is actually relevant at all.
was (Author: stefan.miklosovic):
[~vinaykumarcse]
yes, this was done on purpose, I think I had this discussion with Marcus
privately, the thing is that I dont know how to propagate map<string, string>
from nodetool's enableauditlogging - there is not any way to pass map from the
command line (at least the straightforward one). If you look closely into
NodeProbe, that patch contains another enableAuditLog method which can accept a
map. It is there for cases somebody really wants to pass some parameters via
map there via JMX. There is as well the original method without that map,
because in tooling like JConsole, that method is not invokable anymore if it
contains a map, so there is not any way to invoke it via JMX, hence the
original method is left there for this purpose.
[~marcuse] also raised an interesting issue that it feels overall "slightly
wrong" to have this enable / disable method there at all. One could just
disable logging, do something bad and enable it again. Hence the question is if
that nodetool command is actually relevant at all.
> Provide ability to configure IAuditLogger
> -----------------------------------------
>
> Key: CASSANDRA-15748
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15748
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently there is a parameterless constructor expected for IAuditLogger
> instances. There is not any way how to "inject" configuration properties from
> cassandra.yaml into these concrete classes. This would be very handy for
> custom IAuditLogger implementations.
>
> PR: [https://github.com/apache/cassandra/pull/555]
> [|https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15748]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
