[
https://issues.apache.org/jira/browse/CASSANDRA-15806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106742#comment-17106742
]
Ekaterina Dimitrova edited comment on CASSANDRA-15806 at 5/14/20, 12:04 AM:
----------------------------------------------------------------------------
LGTM
- Changed the field name from Is Transient to IsTransient, considering the
format of the rest of them in the list.
- CHANGES.txt updated
[Branch | https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15806]
I think running the unit tests and inJVM for this one is enough. They were
green here:
[Java 8 unit tests |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/254a32b9-8011-4137-8c4f-605fcf4f7593/jobs/695]
[Java 11 unit tests |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/6ab777ee-8038-499e-903f-5fcbf9c00786/jobs/707]
[Java 8 inJVM |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/254a32b9-8011-4137-8c4f-605fcf4f7593/jobs/694]
[Java 11 inJVM |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/6ab777ee-8038-499e-903f-5fcbf9c00786/jobs/693]
[~brandon.williams], do you want to check and commit? (not a committer yet)
was (Author: e.dimitrova):
LGTM Just changed the field name from Is Transient to IsTransient, considering
the format of the rest of them in the list.
I think running the unit tests and inJVM for this one is enough. They were
green here:
[Java 8 unit tests |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/254a32b9-8011-4137-8c4f-605fcf4f7593/jobs/695]
[Java 11 unit tests |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/6ab777ee-8038-499e-903f-5fcbf9c00786/jobs/707]
[Java 8 inJVM |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/254a32b9-8011-4137-8c4f-605fcf4f7593/jobs/694]
[Java 11 inJVM |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/131/workflows/6ab777ee-8038-499e-903f-5fcbf9c00786/jobs/693]
[~brandon.williams], do you want to check and commit? (not a committer yet)
> C* 4.0 is missing a way to identify transient/non-transient SSTables on disk
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-15806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15806
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
> Reporter: sequoyha pelletier
> Assignee: sequoyha pelletier
> Priority: Normal
> Fix For: 4.0
>
> Attachments: 15806-4.0.txt
>
>
> Currently, there is no way to identify SSTables that were created as
> transient replicated data. Even thought the feature is experimental we should
> open that up for those that want to experiment. This seems to be an
> oversight. I have added the missing line of code to the SStableMetadataViewer
> and will attach a patch shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
