[ https://issues.apache.org/jira/browse/CASSANDRA-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107259#comment-17107259 ]
Andres de la Peña edited comment on CASSANDRA-14361 at 5/14/20, 1:59 PM: ------------------------------------------------------------------------- [~benbromhead] it seems the patch is needing a rebase, it conflicts with CASSANDRA-7544. Besides that, I think that the threshold property would probably be better placed in cassandra.yaml. Also, I'm not sure if we want a property to disable the {{getAllByName}} call and fallback to the old behaviour, so it doesn't create problems with existing setups, wdyt? Probably it's not needed since 4.0 is a major version, although we should add a note in NEWS.txt about the new behaviour. was (Author: adelapena): [~benbromhead] it seems the patch is needing a rebase, it conflicts with CASSANDRA-7544. Besides that, I think that the threshold property would probably be better placed in cassandra.yaml. Also, I'm not sure if we want a property to disable the {{getAllByName}} call and fallback to the old behaviour, so it doesn't create problems with existing setups, wdyt? > Allow SimpleSeedProvider to resolve multiple IPs per DNS name > ------------------------------------------------------------- > > Key: CASSANDRA-14361 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14361 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config > Reporter: Ben Bromhead > Assignee: Ben Bromhead > Priority: Low > Fix For: 4.0 > > > Currently SimpleSeedProvider can accept a comma separated string of IPs or > hostnames as the set of Cassandra seeds. hostnames are resolved via > InetAddress.getByName, which will only return the first IP associated with an > A, AAAA or CNAME record. > By changing to InetAddress.getAllByName, existing behavior is preserved, but > now Cassandra can discover multiple IP address per record, allowing seed > discovery by DNS to be a little easier. > Some examples of improved workflows with this change include: > * specify the DNS name of a headless service in Kubernetes which will > resolve to all IP addresses of pods within that service. > * seed discovery for multi-region clusters via AWS route53, AzureDNS etc > * Other common DNS service discovery mechanisms. > The only behavior this is likely to impact would be where users are relying > on the fact that getByName only returns a single IP address. > I can't imagine any scenario where that is a sane choice. Even when that > choice has been made, it only impacts the first startup of Cassandra and > would not be on any critical path. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org