[
https://issues.apache.org/jira/browse/CASSANDRA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110558#comment-17110558
]
Dinesh Joshi commented on CASSANDRA-15636:
------------------------------------------
hi [~Dean Z], sorry about the delay in responding. I did a quick scan of your
patch and I think this ticket should go a lot further. However, if you're
looking for LHF with a bit more clarity, please take a look at the flakey test
jiras that are open. This ticket is a bit nebulous so I'd avoid it for now.
> Refactor protocol related code to eliminate magic numbers
> ---------------------------------------------------------
>
> Key: CASSANDRA-15636
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15636
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
> Reporter: Dinesh Joshi
> Priority: Low
> Attachments: patch.diff
>
>
> Parts of Cassandra's codebase has protocol related magic numbers. It makes
> the code hard to understand. We should refactor the code to remove magic
> numbers and instead replace them with versioned constants. This will help
> make the code clearer. Example:
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/ErrorMessage.java#L288
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
