[ https://issues.apache.org/jira/browse/CASSANDRA-15812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117787#comment-17117787 ]
Benjamin Lerer commented on CASSANDRA-15812: -------------------------------------------- The patch looks good to me. I just wonder if it makes sense to allow users to use the blocking behavior for the {{ValidationExecutor}} as we know that this approach might lead to blocking the ANTI_ENTROPY stage. Is there a scenario in which using that behavior would be better? > Submitting Validation requests can block ANTI_ENTROPY stage > ------------------------------------------------------------ > > Key: CASSANDRA-15812 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15812 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair > Reporter: Sam Tunnicliffe > Assignee: Sam Tunnicliffe > Priority: Normal > Fix For: 4.0-alpha > > > RepairMessages are handled on Stage.ANTI_ENTROPY, which has a thread pool > with core/max capacity of one, ie. we can only process one message at a time. > > Scheduling validation compactions may however block the stage completely, by > blocking on CompactionManager's ValidationExecutor while submitting a new > validation compaction, in cases where there are already more validations > running than can be executed in parallel. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org