[
https://issues.apache.org/jira/browse/CASSANDRA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121396#comment-17121396
]
David Capwell edited comment on CASSANDRA-15685 at 6/1/20, 11:24 PM:
---------------------------------------------------------------------
[~bdeggleston] [~marcuse] could we get your thoughts on this? preview repair
isn't allowed to be run concurrently with IR, but IR completes before the
message is handled on the participant; the below is impacted by this race
condition.
{code}
nodetool repair foo bar
# does not look to be running concurrently with the above IR, since it was
notified of success
# but the commit message may not have been seen yet which cause this to be
concurrent with the above
nodetool repair foo bar --validate
{code}
See here
https://github.com/apache/cassandra/blob/ec1808a34f9aa5ae0b956c1527828566f4ba2be5/src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java#L234-L244.
We send the message but don't make sure its ack on.
was (Author: dcapwell):
[~bdeggleston] [~marcuse] could we get your thoughts on this? preview repair
isn't allowed to be run concurrently with IR, but IR completes before the
message is handled on the participant; the below is impacted by this race
condition.
{code}
nodetool repair foo bar
# does not look to be running concurrently with the above IR, since it was
notified of success
# but the commit message may not have been seen yet which cause this to be
concurrent with the above
nodetool repair foo bar --validate
{code}
> flaky testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Kevin Gallardo
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Attachments: log-CASSANDRA-15685.txt, output
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Observed in:
> https://app.circleci.com/pipelines/github/newkek/cassandra/34/workflows/1c6b157d-13c3-48a9-85fb-9fe8c153256b/jobs/191/tests
> Failure:
> {noformat}
> testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.PreviewRepairTest.testWithMismatchingPending(PreviewRepairTest.java:97)
> {noformat}
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15685]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
