[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126974#comment-17126974
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 6/5/20, 5:49 PM:
--------------------------------------------------------------------------
*Summary:*
This branch contains:
- [first commit |
https://github.com/ekaterinadimitrova2/cassandra/commit/a8a9145a032a9f2d9b74369f2e4474a210aa5b99]
which contains parameters name changes as requested; backward compatibility
with the old names; Proposed new structure into [sections
|https://issues.apache.org/jira/browse/CASSANDRA-15234?focusedCommentId=17057969&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17057969]
for cassandra.yaml.
- the [second commit |
https://github.com/ekaterinadimitrova2/cassandra/commit/032fbd8cca1d7b5b96738bd96d9672864426d718]
implements the functionality which gives the end users the opportunity to
attach units suffixes to Memory, Duration, Rates parameters.
- [third commit
|https://github.com/ekaterinadimitrova2/cassandra/commit/68f89503e6e6f30e8f6df1374cb553f243f0068e]
is a ninja fix of one line which was changed in a wrong way during the latest
rebase.
- [fourth commit
|https://github.com/ekaterinadimitrova2/cassandra/commit/8389010d704a9524a1c36d96f9e4d8179a8e2044]
is to return the default config.yml
This patch requires custom [ [DTests |
https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-3]
] which run successfully with the following patch of [CCM
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-3]
DTests - requirements.txt should be updated back to the original one before
commit!
The DTests are not backward compatible with the yaml file without units
suffixes.
This part is covered by a unit test which tests the successful load of the
values of the parameters without units as per the old format.
[ [trunk
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-3-rebase
] ] [ [DTests |
https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-3]
] [ [CCM |https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-3] ]
[ [JAVA8
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/193/workflows/718c8a04-385b-4ddc-ac2e-9291c37b1f1e]
] [ [JAVA11
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/193/workflows/6cd6048d-5daf-4490-a5d3-b5c3178a0757
] ]
Attached to the ticket is the log of the successful runs of the few failing
JAVA8 DTests in CircleCI. I ran them locally after fixing lost line of code as
it didn't make sense to me to rerun the whole suite of tests.
*Last update:* after rebase and a few nits on my end, we have only 1 DTest and
1 Unit test failing in JAVA11. Unrelated known failures.
CQLSH JAVA11 tests are not currently available in CircleCI.
----
This branch is a class of Accessors System properties. *This patch could be
considered separate of the previous one.* It doesn't require custom DTests or
custom CCM.
[ [trunk
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-5] ] [
[JAVA8 CI
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/195/workflows/ebd771ac-d71c-49ea-872b-00b534d9d5c6]
] [ [JAVA11 CI
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/195/workflows/19a3254b-cd7a-4e4f-856f-f314546ff9d7]
]
There are 1 DTest and 1 Unit unrelated failing tests in JAVA11. Should check
for tickets logged.
*WARNING:* Before commit return to the default requirements.txt file
was (Author: e.dimitrova):
*Summary:*
This branch contains:
- [first commit |
https://github.com/ekaterinadimitrova2/cassandra/commit/a8a9145a032a9f2d9b74369f2e4474a210aa5b99]
which contains parameters name changes as requested; backward compatibility
with the old names; Proposed new structure into [sections
|https://issues.apache.org/jira/browse/CASSANDRA-15234?focusedCommentId=17057969&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17057969]
for cassandra.yaml.
- the [second commit |
https://github.com/ekaterinadimitrova2/cassandra/commit/032fbd8cca1d7b5b96738bd96d9672864426d718]
implements the functionality which gives the end users the opportunity to
attach units suffixes to Memory, Duration, Rates parameters.
- [third commit
|https://github.com/ekaterinadimitrova2/cassandra/commit/68f89503e6e6f30e8f6df1374cb553f243f0068e]
is a ninja fix of one line which was changed in a wrong way during the latest
rebase.
- [fourth commit
|https://github.com/ekaterinadimitrova2/cassandra/commit/8389010d704a9524a1c36d96f9e4d8179a8e2044]
is to return the default config.yml
This patch requires custom [ [DTests |
https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-3]
] which run successfully with the following patch of [CCM
|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-3]
DTests - requirements.txt should be updated back to the original one before
commit!
The tests are not backward compatible with the yaml file without units suffixes.
This part is covered by a unit test which tests the successful load of the
values of the parameters without units as per the old format.
[ [trunk
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-3-rebase
] ] [ [DTests |
https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-3]
] [ [CCM |https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234-3] ]
[ [JAVA8
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/193/workflows/718c8a04-385b-4ddc-ac2e-9291c37b1f1e]
] [ [JAVA11
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/193/workflows/6cd6048d-5daf-4490-a5d3-b5c3178a0757
] ]
Attached to the ticket is the log of the successful runs of the few failing
JAVA8 DTests in CircleCI. I ran them locally after fixing lost line of code as
it didn't make sense to me to rerun the whole suite of tests.
*Last update:* after rebase and a few nits on my end, we have only 1 DTest and
1 Unit test failing in JAVA11. Unrelated known failures.
CQLSH JAVA11 tests are not currently available in CircleCI.
----
This branch is a class of Accessors System properties. *This patch could be
considered separate of the previous one.* It doesn't require custom DTests or
custom CCM.
[ [trunk
|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15234-5] ] [
[JAVA8 CI
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/195/workflows/ebd771ac-d71c-49ea-872b-00b534d9d5c6]
] [ [JAVA11 CI
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/195/workflows/19a3254b-cd7a-4e4f-856f-f314546ff9d7]
]
There are 1 DTest and 1 Unit unrelated failing tests in JAVA11. Should check
for tickets logged.
*WARNING:* Before commit return to the default requirements.txt file
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
