[ https://issues.apache.org/jira/browse/CASSANDRA-15842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127991#comment-17127991 ]
Berenguer Blasi commented on CASSANDRA-15842: --------------------------------------------- Icwym but on the other hand with that code we wouldn't be reporting on the missing service start, silently swallowing it. If having that service started is a requirement on cdc what about this one instead? {code:java} public void shutdown() { if (cdcSizeCalculationExecutor == null) throw new IllegalStateException("Attempting to shutdown service X when it has never been started. Did you miss to start it?"); <rest of shutdown code here> } {code} > Fix flaky org.apache.cassandra.schema.SchemaTest.testTransKsMigration-cdc > ------------------------------------------------------------------------- > > Key: CASSANDRA-15842 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15842 > Project: Cassandra > Issue Type: Bug > Components: Test/unit > Reporter: Berenguer Blasi > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-beta > > Time Spent: 20m > Remaining Estimate: 0h > > Failing for the past [28 > builds|https://ci-cassandra.apache.org/job/Cassandra-trunk/153/testReport/org.apache.cassandra.schema/SchemaTest/testTransKsMigration_cdc/] > java.lang.NullPointerException > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC$CDCSizeTracker.shutdown(CommitLogSegmentManagerCDC.java:312) > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.shutdown(CommitLogSegmentManagerCDC.java:89) > at > org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:413) > at > org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467) > at > org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:785) > at > org.apache.cassandra.schema.SchemaTest.testTransKsMigration(SchemaTest.java:46) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org