[ 
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-15852:
--------------------------------------
    Reviewers: David Capwell, David Capwell  (was: David Capwell)
               David Capwell, David Capwell
       Status: Review In Progress  (was: Patch Available)

Mostly LGTM

* 
https://github.com/krummas/cassandra/commit/ee0a5f2a849b8a11d760ca2975a61fd4bbdc1735#diff-040c2f1cb2ba51b14c7e249412d6574eR62
 Can we use a custom exception here, or add a message and verify the message?  
RuntimeException can be thrown in many locations, so this test could pass 
without triggering this condition.

> Handle errors in StreamSession#prepare
> --------------------------------------
>
>                 Key: CASSANDRA-15852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Streaming
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} - 
> this makes a stream initiator hang forever if an error is thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to