[ 
https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140906#comment-17140906
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-15877 at 6/20/20, 12:56 AM:
----------------------------------------------------------------------------

Thanks [~Bereng]

All three fail both on trunk and with my patch.

For those that are v11, I think just Jenkins runs the test suite only for Java 
8, as far as I remember?

For the one failing in Java 8, I saw it this week also with other CI runs and I 
am not sure why it does not fail in Jenkins.

I will raise tickets for those on Monday but I believe this one should be ready 
for commit.

[~brandon.williams], can you check and commit this patch, please, if you don't 
have any concerns, of course? 

 


was (Author: e.dimitrova):
Thanks [~Bereng]

All three fail both on trunk and with my patch.

For those that are v11, I think just Jenkins runs the test suite only for Java 
8, as far as I remember?

For the one failing in Java 8, I saw it this week also with other CI runs and I 
am not sure why it is not in Jenkins.

I will raise tickets for those on Monday but I believe this one should be ready 
for commit.

[~brandon.williams], can you check and commit this patch, please, if you don't 
have any concerns, of course? 

 

> Followup on CASSANDRA-15600
> ---------------------------
>
>                 Key: CASSANDRA-15877
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Virtual Nodes
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0, 4.0-alpha
>
>         Attachments: Screen Shot 2020-06-12 at 3.21.18 PM.png
>
>
> As part of CASSANDRA-15600  generateSplits method replaced the 
> generateRandomTokens for NoReplicationAwareTokenAllocator.  generateSplits 
> should be used also in ReplicationAwareTokenAllocator.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to