[
https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144894#comment-17144894
]
Sylvain Lebresne commented on CASSANDRA-13994:
----------------------------------------------
bq. can someone please clarify if we want to move forward with this?
I vote yes (see additional context on the mailing list).
bq. This ticket was deemed too risky and would 'invalidate testing'
I don't know where those qualifications come from, and on what they were based,
but they simply don't match what this ticket does and the attached patch. This
ticket just removes dead code, not _that_ much of it, and it's hardly a
chirurgical removal. There is no testing invalidation nor invasive changes
involved. This is fake news.
I think people just got scared because this is compact storage and that has
historically been messy. But the truth is that nearly all the complex and
invasive removal of legacy code has been committed _years_ ago, mainly by
CASSANDRA-11115, CASSANDRA-12716 and CASSANDRA-10857. This ticket is just
cleaning 2 small left-over, that's all.
> Remove COMPACT STORAGE internals before 4.0 release
> ---------------------------------------------------
>
> Key: CASSANDRA-13994
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13994
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
> Reporter: Alex Petrov
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-alpha
>
>
> 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after
> [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of
> the related functionality is useless.
> There are still some things to consider:
> 1. One of the system tables (built indexes) was compact. For now, we just
> added {{value}} column to it to make sure it's backwards-compatible, but we
> might want to make sure it's just a "normal" table and doesn't have redundant
> columns.
> 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is
> trivial, but this would mean that all built indexes will be defunct. We could
> log a warning for now and ask users to migrate off those for now and
> completely remove it from future releases. It's just a couple of classes
> though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
