[ 
https://issues.apache.org/jira/browse/CASSANDRA-15901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149320#comment-17149320
 ] 

Berenguer Blasi commented on CASSANDRA-15901:
---------------------------------------------

If I am following you correctly you're proposing returning 
{{InetAddress.getLoopbackAddress()}} when {{listen_address}} is null and not 
resolvable:
 * The original problem we are facing imo is that the specified 
{{listen_address}} in the yaml is not being loaded, hence is not effective and 
using a default fallback. I would argue here you want the {{listen_address}} 
you have in the test yaml to be effective rather than being resilient to a 
default fallback node mis-config? In fact it's actually good we found out we 
were not honoring the test yaml.
 * I played a bit on DD to try to load the address config sooner looking for 
alternatives, as you did, to the wall of test fixes. But some access the method 
well before the {{listen_address}} is loaded. So that didn't work.
 * On your proposed fix it sounds great but maybe orthogonal (iiuc). Also would 
we prefer to fail if we can't resolve the machine name?  I read a bit about 
{{{{getLoopbackAddress}}}} and you might have some ipv4 vs ipv6 lo address 
being returned apparently :thinking:...

So TLDR: we need to make the yaml effective, I wasn't able to find a smarter 
alternative & your proposal could be a new ticket instead. Wdyt makes sense?

> Fix unit tests to load test/conf/cassandra.yaml (so to listen on a valid ip)
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15901
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15901
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-rc
>
>
> Many of the ci-cassandra jenkins runs fail on {{ip-10-0-5-5: Name or service 
> not known}}. CASSANDRA-15622 addressed some of these but many still remain. 
> Currently test C* nodes are either failing or listening on a public ip 
> depending on which agent they end up.
> The idea behind this ticket is to make ant force the private VPC ip in the 
> cassandra yaml when building, this will force the nodes to listen on the 
> correct ip.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to