[ 
https://issues.apache.org/jira/browse/CASSANDRA-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152040#comment-17152040
 ] 

Andres de la Peña commented on CASSANDRA-10968:
-----------------------------------------------

The fix looks good to me. I have run CI again:

||branch||utest||dtest||
|2.1 
|[167|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/167/]|[201|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/201/]|
|2.2 
|[168|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/168/]|[202|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/202/]|
|3.0 
|[169|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/169/]|[203|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/203/]|
|3.11|[170|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/170/]|[204|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/204/]|
|4.0 
|[171|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/171/]|[205|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/205/]|

Dtests haven't finished yet. 2.1 CI seems to have failed to build, and indeed 
we don't seem to have a regular CI build for it. For 2.2 there are failures in 
{{SSTableRewriterTest}} that also happen in the base branch, so they don't seem 
related.

For sure we should at least apply the fix since 2.2. I'm not sure this is 
critical enough for 2.1, but the fix is quite small so probably it won't be a 
problem if we include that branch, although the lack of CI for the branch is a 
bit worrying.


> When taking snapshot, manifest.json contains incorrect or no files when 
> column family has secondary indexes
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10968
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10968
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/2i Index
>            Reporter: Fred A
>            Assignee: Aleksandr Sorokoumov
>            Priority: Normal
>              Labels: lhf
>             Fix For: 2.2.x, 3.0.x, 3.11.x
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> xNoticed indeterminate behaviour when taking snapshot on column families that 
> has secondary indexes setup. The created manifest.json created when doing 
> snapshot, sometimes contains no file names at all and sometimes some file 
> names. 
> I don't know if this post is related but that was the only thing I could find:
> http://www.mail-archive.com/user%40cassandra.apache.org/msg42019.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to