[
https://issues.apache.org/jira/browse/CASSANDRA-15920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15920:
--------------------------------------
Reviewers: David Capwell, David Capwell (was: David Capwell)
David Capwell, David Capwell
Status: Review In Progress (was: Patch Available)
Left comments in PR.
My main question is on the paging setup. I don't mind if this is added later,
but the `QueryResult` that is used for paging doesn't have changes to add
warning.
Overall I am +1 to this. Please add the builder warning support, and will
leave up to you on pager in scope or not for this JIRA.
> SimpleQueryResult should contain client warnings
> ------------------------------------------------
>
> Key: CASSANDRA-15920
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15920
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: Caleb Rackliffe
> Assignee: Caleb Rackliffe
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-beta
>
>
> There isn't a way to get query warnings generated via \{{ClientWarn}} using
> the existing \{{ICoordinator}} interface. The simplest possible change here
> would be to...
> 1.) Make sure we activate warning collection before queries start.
> 2.) Rip warnings out of \{{ClientWarn}} when queries return.
> 3.) Include those warnings when we create \{{SimpleQueryResult}}.
> {\{QueryResult}} might not need to expose the warnings, given not all its
> implementations would be expected to have them, but we could just return an
> empty list of warnings by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
