[
https://issues.apache.org/jira/browse/CASSANDRA-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156333#comment-17156333
]
Michael Semb Wever edited comment on CASSANDRA-15809 at 7/12/20, 4:32 PM:
--------------------------------------------------------------------------
Thanks [~shylaja.koko...@intel.com]!!
Couple of comments, and things we need to take note of…
- Rolling this out will depend on deleting/renaming all the build definitions
that are getting changed to type: {{matrixJob}}. That means all links to saved
build pages (and their artefacts) will break.
Otherwise we will hit the error:
{noformat}
ERROR: Type of item "Cassandra-template-artifacts" does not match existing
type, item type can not be changed
{noformat}
- The link to latest artefacts will break, as it changes to include either of
the jdk labels.
- The deb and rpm packaging need the java_version passed into their containers
and scripts.
- The deb and rpm packaging has to quote the path arguments, as jdk labels
contain spaces (and the label name is used as a folder in the workspace).
- The javadoc was broken on jdk11, as the {{jdk11-javac-exports}} were never
getting passed to it.
Apart from the first two points (which have to be dealt with at deploy/commit
time), these things are addressed in the updated patches:
- your updated patch [~shylaja.koko...@intel.com] to
[cassandra-builds|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15809--jenkins-jdk11-builds]
- the additional patch to
[cassandra|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_15809]
was (Author: michaelsembwever):
Thanks [~shylaja.koko...@intel.com]!!
Couple of comments, and things we need to take note of…
- Rolling this out will depend on deleting/renaming all the build definitions
that are getting changed to type: {{matrixJob}}. That means all links to saved
build pages (and their artefacts) will break.
Otherwise we will hit the error:
{noformat}
ERROR: Type of item "Cassandra-template-artifacts" does not match existing
type, item type can not be changed
{noformat}
- The link to latest artefacts will break, as it changes to include either of
the jdk labels.
- The deb and rpm packaging need the java_version passed into their containers
and scripts.
- The deb and rpm packaging has to quote the path arguments, as jdk labels
contain spaces (and the label name is used as a folder in the workspace).
- The javadoc was broken on jdk11, as the {{jdk11-javac-exports}} were never
getting passed to it.
Apart from the first two points (which have to be dealt with at deploy/commit
time), these things are addressed in the updated patches:
- your updated patch [~shylaja.koko...@intel.com] to
[cassandra-builds|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15809--jenkins-jdk11-builds]
- the additional patch to
[cassandra|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_15809]
> ASF CI builds for JDK11
> -----------------------
>
> Key: CASSANDRA-15809
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15809
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI
> Reporter: Michael Semb Wever
> Assignee: shylaja kokoori
> Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: Screenshot 2020-05-13 at 09.39.56.png,
> build_with_multiple_jdk.patch
>
>
> ASF CI builds today only run on JDK1.8
> On the Jenkins cluster JDKs from 1.4 through to 15 are available. See
> attached screenshot for naming specifics.
> This ticket is to add JDK11 compile and test targets on Cassandra-trunk, for
> parity to CircleCI's workflows. (There is also the question about
> testing/running on Cassandra-2.2 which needs to support JDK1.7, though
> Cassandra-2.2 is nearing EOL.)
>
> The JDK is specified in the groovy DSL:
> [https://github.com/apache/cassandra-builds/blob/master/jenkins-dsl/cassandra_job_dsl_seed.groovy#L11]
>
>
> Some examples:
> * CircleCI JDK1.8 workflow example. This builds with JDK1.8 and tests with
> both JDK1.8 and JDK11.
> **
> [https://app.circleci.com/pipelines/github/dcapwell/cassandra/259/workflows/bce6fbf9-a4a3-4bfd-be7d-3e7961b440d8]
> * CircleCI JDK11 workflow example. This builds and tests only with JDK11.
> **
> [https://app.circleci.com/pipelines/github/dcapwell/cassandra/259/workflows/38e7d77e-1d5e-47f7-a462-277665428306]
> * Jenkins Cqlshlib tests showing matrix builds:
> **
> [https://ci-cassandra.apache.org/view/Cassandra%204.0/job/Cassandra-trunk-cqlsh-tests/]
>
> Background
> thread:[https://lists.apache.org/thread.html/rbaeb960901fa53b50227b37d64e5a456b68f749f4229c6e3e086ff85%40%3Cdev.cassandra.apache.org%3E]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
