[
https://issues.apache.org/jira/browse/CASSANDRA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168261#comment-17168261
]
David Capwell commented on CASSANDRA-16003:
-------------------------------------------
It would also be good to fix the asserts as they are not actionable; they
should inform what happened to cause the issue (such as print out stderr if it
is expected to be empty but was not)
> ToolRunner added in CASSANDRA-15942 isn't portable
> --------------------------------------------------
>
> Key: CASSANDRA-16003
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16003
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: David Capwell
> Priority: Normal
> Fix For: 4.0-beta
>
>
> The JVM will output to stderr on some environments to show what flags that
> were picked up, when this happens all tests which validate stderr start to
> fail. This was found in the org.apache.cassandra.tools.ClearSnapshotTest as
> it switched to use the ToolRunner; below is a sample failure on my laptop (I
> had to modify the asserts since they don’t include the input)
> {code}
> java.lang.AssertionError:
> Expecting empty but was:<"Picked up _JAVA_OPTIONS:
> -Djava.net.preferIPv4Stack=true
> ">
> at
> org.apache.cassandra.tools.ToolRunner.assertEmptyStdErr(ToolRunner.java:339)
> at
> org.apache.cassandra.tools.ToolRunner.waitAndAssertOnCleanExit(ToolRunner.java:334)
> at
> org.apache.cassandra.tools.ClearSnapshotTest.testClearSnapshot_RemoveMultiple(ClearSnapshotTest.java:91)
> {code}
> Here _JAVA_OPTIONS is used globally on my system so fails the test; there is
> also JAVA_TOOL_RUNNER which is used the same way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
