[ 
https://issues.apache.org/jira/browse/CASSANDRA-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171556#comment-17171556
 ] 

Jeremy Hanna edited comment on CASSANDRA-13701 at 8/5/20, 3:29 PM:
-------------------------------------------------------------------

I started down this road but don't think I can get through fixing all of the 
dtests.  On this line in bootstrap-test.py I changed the time.sleep to 10 
seconds and it appears to solve that problem - 
https://github.com/apache/cassandra-dtest/blob/master/bootstrap_test.py#L485

However there were many tests with replace_address that I'm not sure about.  I 
don't know how or why replace address would be affected by the new token 
allocation algorithm.  Dimitar said something about parallel bootstrap but I 
don't see that - sometimes no_wait or wait_other_notice is true or false so I 
thought it was that, but perhaps someone more familiar with ccm could see.

I'm sorry - I really want this to get in for the release but I don't have the 
time to dedicate to learning dtest at a deeper level to fix all of these in 
time.


was (Author: jeromatron):
I started down this road but don't think I can get through fixing all of the 
dtests.  On this line in bootstrap-test.py I changed the time.sleep to 10 
seconds and it appears to solve that problem - 
https://github.com/apache/cassandra-dtest/blob/master/bootstrap_test.py#L485

However there were many tests with replace_address that I'm not sure about.  I 
don't know how or why replace address would be affected by the new token 
allocation algorithm.  Dmitri said something about parallel bootstrap but I 
don't see that - sometimes no_wait or wait_other_notice is true or false so I 
thought it was that, but perhaps someone more familiar with ccm could see.

I'm sorry - I really want this to get in for the release but I don't have the 
time to dedicate to learning dtest at a deeper level to fix all of these in 
time.

> Lower default num_tokens
> ------------------------
>
>                 Key: CASSANDRA-13701
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13701
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Config
>            Reporter: Chris Lohfink
>            Priority: Low
>             Fix For: 4.0-alpha
>
>
> For reasons highlighted in CASSANDRA-7032, the high number of vnodes is not 
> necessary. It is very expensive for operations processes and scanning. Its 
> come up a lot and its pretty standard and known now to always reduce the 
> num_tokens within the community. We should just lower the defaults.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to