[
https://issues.apache.org/jira/browse/CASSANDRA-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180072#comment-17180072
]
Jordan West commented on CASSANDRA-16054:
-----------------------------------------
Thanks [~maedhroz]! Pushed a new commit (will squash) with some updates based
on your review. Some comments below:
* I wanted to use a cluster because of the schema agreement reason you noticed
as well as wanting to test the entire stack for how it behaved in this state,
not just the local engine. The upgradesstables call is there because the test
is only meant to show these guarantees hold after its been run.
* I've made the suggested changes to
{{testDropCompactWithClusteringAndValueColumn,}}
{{testDropCompactWithClusteringAndValueColumnWithDeletesAndWrites}}, along with
some of your other suggestions.
* The visibility changes in {{AbstractCluster}} and
{{DelegatingInvokableInstance}} were from another test. I've removed them.
Since I'm not modifying the files anymore I didn't remove the import of
{{org.apache.cassandra.distributed.shared.NetworkTopology}} in
{{DelegatingInvokableInstance}}
{quote}Both tests issue coordinator queries at CL=ONE rather than using
executeInternal(). Are we guaranteed that the former can't hit the wrong node?
{quote}
That is my understanding.
> Regression Test for Compact Storage Upgrades When Table Has Clustering and
> Value Column
> ----------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16054
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16054
> Project: Cassandra
> Issue Type: Task
> Components: Legacy/CQL
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Add a regression test that shows that dropping compact storage on tables that
> have clustering columns and a value column defined are safe after upgrading
> sstables in 3.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
