[ https://issues.apache.org/jira/browse/CASSANDRA-16064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181464#comment-17181464 ]
David Capwell commented on CASSANDRA-16064: ------------------------------------------- I also feel I should backport this to 3.0. I started this in 3.0 and found a bug where we don't include the table name's size in our estimate. We didn't use sizeOf for correctness like we do in 4.0, so less critical. > Add test which validates that Message serializedSize(version) == > serialize(out, version).length > ----------------------------------------------------------------------------------------------- > > Key: CASSANDRA-16064 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16064 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode > Reporter: David Capwell > Assignee: David Capwell > Priority: Normal > Fix For: 4.0-beta > > > In 4.0 we require serializedSize(version) == serialize(out, version).length > for correctness in post40 message format as we write it into the message > header. Given that this is a strong requirement for correct deserialization > of the message, we should have tests which help enforce this property. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org