[ 
https://issues.apache.org/jira/browse/CASSANDRA-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-2626:
--------------------------------------

    Attachment: 2626.txt

Ah, you've nailed it. Thanks for tracking that down.

Patch attached to avoid re-wrapping an already unmodifiable collection. 
(Surprised Collections.unmodifiable... doesn't do this.)

We may also want to look at using ImmutableSet 
(http://guava-libraries.googlecode.com/svn/trunk/javadoc/com/google/common/collect/ImmutableSet.html)
 instead of HashSet wrapped in UnmodifiableSet. (ImmutableSet claims to 
"perform significantly better than HashSet for objects with very fast 
Object.hashCode() implementations.")

> stack overflow while compacting
> -------------------------------
>
>                 Key: CASSANDRA-2626
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2626
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Documentation & website
>    Affects Versions: 0.8 beta 1
>            Reporter: Terje Marthinussen
>         Attachments: 2626.txt
>
>
> This is a trunk build from May 3.
> After adding  CASSANDRA-2401, I have gotten the following on several nodes.
> I am not 100% sure right now if it is related to 2401 but it may seem likely.
> Unfortunately, as often is the case with stack overflows, I don't see the 
> start of the stack
> ERROR [CompactionExecutor:17] 2011-05-09 07:56:32,479 
> AbstractCassandraDaemon.java (line 112) Fatal exception in thread 
> Thread[CompactionExecutor:17,1,main]
> java.lang.StackOverflowError
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)
>         at 
> java.util.Collections$UnmodifiableCollection.size(Collections.java:998)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to