[ https://issues.apache.org/jira/browse/CASSANDRA-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195915#comment-17195915 ]
Marcus Eriksson commented on CASSANDRA-14103: --------------------------------------------- bq. LeveledGenerations.maybeVerifyLevels this is only runs in the tests, so we don't throw anything during normal operation ({{private final boolean strictLCSChecksTest = Boolean.getBoolean(Config.PROPERTY_PREFIX + "test.strict_lcs_checks");}}). Added an ERROR log when adding sstables if it already exists on the wrong level, then removes it and continues to add it at the sstable-metadata-level fixed the nits > Fix potential race during compaction strategy reload > ---------------------------------------------------- > > Key: CASSANDRA-14103 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14103 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction > Reporter: Paulo Motta > Assignee: Marcus Eriksson > Priority: Urgent > Attachments: 3.11-14103-dtest.png, 3.11-14103-testall.png, > trunk-14103-dtest.png, trunk-14103-testall.png > > > When the compaction strategies are reloaded after disk boundary changes > (CASSANDRA-13948), it's possible that a recently finished SSTable is added > twice to the compaction strategy: once when the compaction strategies are > reloaded due to the disk boundary change ({{maybeReloadDiskBoundarie}}), and > another when the {{CompactionStrategyManager}} is processing the > {{SSTableAddedNotification}}. > This should be quite unlikely because a compaction must finish as soon as the > disk boundary changes, and even if it happens most compaction strategies > would not be affected by it since they deduplicate sstables internally, but > we should protect against such scenario. > For more context see [this > comment|https://issues.apache.org/jira/browse/CASSANDRA-13948?focusedCommentId=16280448&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280448] > from Marcus. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org