[ https://issues.apache.org/jira/browse/CASSANDRA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196514#comment-17196514 ]
David Capwell commented on CASSANDRA-15160: ------------------------------------------- Ok I think I figured out the python dtest issues; https://github.com/krummas/cassandra/commit/8bfdb0b6eed1e74ad6a0c8f4fac94980db19fd49#diff-ed04b58f62a097d7f25c755d487cb1a3R334. The new flag was added to the toString, and the tests search for the toString, so this regex fails https://github.com/apache/cassandra-dtest/blob/master/repair_tests/deprecated_repair_test.py#L168. 3.x jvm-dtests fail since they check the wrong DC; all branches should have (the original test tests dc2, so mainDC only needs to test dc1) {code} // choose a node in the DC that has any replicas IInvokableInstance node = cluster.get(1); Assertions.assertThat(node.config().localDatacenter()).isEqualTo("datacenter1"); {code} Held off merge on the Python dtests. > Add flag to ignore unreplicated keyspaces during repair > ------------------------------------------------------- > > Key: CASSANDRA-15160 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15160 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Normal > > When a repair is triggered on a node in 'dc2' for a keyspace with replication > factor {'dc1':3, 'dc2':0} we just ignore the repair in versions < 3. In 3.0+ > we fail the repair to make sure the operator does not think the keyspace is > fully repaired. > There might be tooling that relies on the old behaviour though, so we should > add a flag to ignore those unreplicated keyspaces > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org