[ 
https://issues.apache.org/jira/browse/CASSANDRA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197076#comment-17197076
 ] 

David Capwell commented on CASSANDRA-16101:
-------------------------------------------

The test I am worried about are (only choose one permutation)

* 
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/FullRepairCoordinatorFastTest.java
* 
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/FullRepairCoordinatorTimeoutTest.java
* 
https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/FullRepairCoordinatorNeighbourDownTest.java

shutting down the cluster is here: 
https://github.com/apache/cassandra/blob/be7c9e22b085d67cf867e53ae9e9fed3d7c2e03c/test/distributed/org/apache/cassandra/distributed/test/RepairCoordinatorBase.java#L87

at this point, the AfterClass method will fail and doesn't have enough details 
to know if the failure is expected or not.

All the tests I know which reuse a cluster have this same problem.

bq.  I'm thinking, if, instead of adding all exceptions as suppressed to the 
first Cause, should we mabye add them as suppressed to ShutdownException itself?

Sounds like a good idea!  Not sure it would help the reuse cluster tests though 
given my point above; close lacks context of what is acceptable and what isn't.

> Make sure we don't throw any uncaught exceptions during in-jvm dtests
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-16101
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16101
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>
> We should assert that we don't throw any uncaught exceptions when running 
> in-jvm dtests



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to