[ https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197591#comment-17197591 ]
Berenguer Blasi edited comment on CASSANDRA-16121 at 9/17/20, 10:21 AM: ------------------------------------------------------------------------ Hi [~e.dimitrova] I updated both patch files. But notice the following which ties to your original comment about using too large resources: - config21 uses {{j8_small_par_executor}} [here|https://github.com/bereng/cassandra/blob/CASSANDRA-16121/.circleci/config-2_1.yml#L399] - {{j8_small_par_executor}} is patched to {{large}} and parallelism of {{10}} [here|https://github.com/bereng/cassandra/blob/trunk/.circleci/config-2_1.yml.mid_res.patch#L19] So my original commit was correct when generating 'large & 10' (it is what the patch does) Shouldn't we instead change the patch to redefine {{j8_small_par_executor}} to 'medium & 1'? was (Author: bereng): Hi [~e.dimitrova] I updated both patch files. But notice the following which ties to your original comment about using too large resources: - config21 uses {{j8_small_par_executor}} [here|https://github.com/bereng/cassandra/blob/CASSANDRA-16121/.circleci/config-2_1.yml#L399] - {{j8_small_par_executor}} is patched lo {{large}} and parallelism of {{10}} [here|https://github.com/bereng/cassandra/blob/trunk/.circleci/config-2_1.yml.mid_res.patch#L19] So my original commit was correct when generating 'large & 10' (it is what the patch does) Shouldn't we instead change the patch to redefine {{j8_small_par_executor}} to 'medium & 1'? > Circleci should run cqlshlib tests as well > ------------------------------------------ > > Key: CASSANDRA-16121 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16121 > Project: Cassandra > Issue Type: Bug > Components: CI, Test/unit > Reporter: Berenguer Blasi > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-beta > > > Currently circleci is not running cqlshlib tests. This resulted in some bugs > not being caught before committing. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org