[
https://issues.apache.org/jira/browse/CASSANDRA-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206225#comment-17206225
]
Chris Lohfink edited comment on CASSANDRA-16161 at 10/2/20, 2:44 PM:
---------------------------------------------------------------------
While tangental to adding a throttle, offheap merkle trees and some of the perf
improvements (ie xor impl and more aggressive dereferencing) has helped a lot
as well (CASSANDRA-15202). Its a lot better in 4.0 from my experiences.
For 3.x though I agree that validation compaction is brutal and this could
provide a workaround to keep functioning. Only question I think is if the
compaction throughput throttle should be shared vs creating a new one but I am
happy with this approach.
The code looks straight forward and am +1 to it. not sure about versions though
was (Author: clohfink):
While tangental to adding a throttle, offheap merkle trees and some of the perf
improvements (ie xor impl and more aggressive dereferencing) has helped a lot
as well (CASSANDRA-15202). Its a lot better in 4.0 from my experiences.
For 3.x though I agree that validation compaction is brutal and this could
provide a workaround to keep functioning. Only question I think is if the
compaction throughput throttle should be shared vs creating a new one but I am
happy with this approach.
The code looks straight forward, +1
> Validation Compactions causing Java GC pressure
> -----------------------------------------------
>
> Key: CASSANDRA-16161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16161
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Cameron Zemek
> Priority: Normal
> Fix For: 3.11.x, 3.11.8
>
> Attachments: 16161.patch
>
>
> Validation Compactions are not rate limited which can cause Java GC pressure
> and result in spikes in latency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
