[ 
https://issues.apache.org/jira/browse/CASSANDRA-15996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215186#comment-17215186
 ] 

Berenguer Blasi commented on CASSANDRA-15996:
---------------------------------------------

That could be it indeed imo. Given NoSpamLogger is to be used in hot paths and 
'currentTimeMillis' resolution issues I'd got for the 'Long.MIN_VALUE' route. 
Also that keeps things within the 'nanotime()' world, sort to speak, so we 
don't inadvertently introduce some perf profile change . Also 
[https://stackoverflow.com/a/54566928/3432945|http://example.com] read was 
interesting.

I have +1'ed the 'Long.MIN_VALUE' PR pending sbdy that knows about the upgrade 
test failures confirming they are indeed unrelated. Nice catch either if it 
turn out to be it or not! :-)

> Fix flaky python dtest test_expiration_overflow_policy_capnowarn - 
> ttl_test.TestTTL
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15996
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15996
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: David Capwell
>            Assignee: Adam Holmberg
>            Priority: Normal
>             Fix For: 3.11.x, 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1860
> {code}
> >           assert warning, 'Log message should be print for CAP and 
> > CAP_NOWARN policy'
> E           AssertionError: Log message should be print for CAP and 
> CAP_NOWARN policy
> E           assert []
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to