[ https://issues.apache.org/jira/browse/CASSANDRA-16048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216490#comment-17216490 ]
Marcus Eriksson commented on CASSANDRA-16048: --------------------------------------------- Added a few nits on the commit, and, as Caleb and Sylvain mentioned, having some logging around this would be good. bq. I skipped adding a flag since we can't detect and "undo" updating the tables that were updated. Could you expand on this? Not sure I follow - sounds like having the flag would be better? > Safely Ignore Compact Storage Tables Where Users Have Defined Clustering and > Value Columns > ------------------------------------------------------------------------------------------ > > Key: CASSANDRA-16048 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16048 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/CQL > Reporter: Jordan West > Assignee: Jordan West > Priority: Normal > Fix For: 4.0-beta > > > Some compact storage tables, specifically those where the user has defined > both at least one clustering and the value column, can be safely handled in > 4.0 because besides the DENSE flag they are not materially different post 3.0 > and there is no visible change to the user facing schema after dropping > compact storage. We can detect this case and allow these tables to silently > drop the DENSE flag while still throwing a start-up error for COMPACT STORAGE > tables that don’t meet the criteria. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org