[ https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219001#comment-17219001 ]
Ekaterina Dimitrova commented on CASSANDRA-16121: ------------------------------------------------- [~dcapwell] [~Bereng] I saw one discussion in the PR which I believe It is quite important so I will leave a comment in the ticket for visibility. Currently no tests are started automatically in Java 11. I would like to encourage people to always run at least the unit and in-jvm tests for Java 11. IMO that is the only stable way to move Java 11 out of being only experimental. Now, one can argue that sometimes in circle we test something quick before final submission and we want a quick j8 check only but I think most of the time people run the full CI in Circle/Jenkins for a patch in final/almost final state While we still don't have Java 11 in Jenkins, we need to be sure at least in Circle we have always at least a minimal coverage, personal opinion. Feel free to disagree :-) > Circleci should run cqlshlib tests as well > ------------------------------------------ > > Key: CASSANDRA-16121 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16121 > Project: Cassandra > Issue Type: Bug > Components: CI, Test/unit > Reporter: Berenguer Blasi > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 4.0-beta > > > Currently circleci is not running cqlshlib tests. This resulted in some bugs > not being caught before committing. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org