[ https://issues.apache.org/jira/browse/CASSANDRA-16146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227175#comment-17227175 ]
Yifan Cai commented on CASSANDRA-16146: --------------------------------------- Hi [~brandon.williams] and [~bdeggleston], Would you please take another look at the fixup to each branch? Links are posted above. Although the CI result looks good when committing, several newly added tests were actually broken since we did not rebase and rerun the CI. In the 3.x branches, the fixup sets the operationMode to normal directly in StorageService when using mock gossip. In the trunk, the fixup corrects the bytebuddy in the failed test class in addition to the operationMode fix in test. > Node state incorrectly set to NORMAL after nodetool disablegossip and > enablegossip during bootstrap > --------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-16146 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16146 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip > Reporter: Yifan Cai > Assignee: Yifan Cai > Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0-beta3 > > Time Spent: 20m > Remaining Estimate: 0h > > At high level, {{StorageService#setGossipTokens}} set the gossip state to > {{NORMAL}} blindly. Therefore, re-enabling gossip (stop and start gossip) > overrides the actual gossip state. > > It could happen in the below scenario. > # Bootstrap failed. The gossip state remains in {{BOOT}} / {{JOINING}} and > code execution exits StorageService#initServer. > # Operator runs nodetool to stop and re-start gossip. The gossip state gets > flipped to {{NORMAL}} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org