[
https://issues.apache.org/jira/browse/CASSANDRA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231040#comment-17231040
]
David Capwell commented on CASSANDRA-16217:
-------------------------------------------
This seems to have broken the upgrade tests, [~ifesdjeen] can you take a look?
https://app.circleci.com/pipelines/github/dcapwell/cassandra/790/workflows/2cee6597-8801-41fb-af14-09943cba006c
{code}
testclasslist:
[echo] Number of test runners: 1
[junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
[junit-timeout] Testsuite:
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest
[junit-timeout] Testsuite:
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest Tests
run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 36.632 sec
[junit-timeout]
[junit-timeout] Testcase:
ignoreDenseCompoundTablesWithValueColumn(org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest):
FAILED
[junit-timeout] missing compound flag
[junit-timeout] junit.framework.AssertionFailedError: missing compound flag
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.lambda$ignoreDenseCompoundTablesWithValueColumn$1(CompactStorage3to4UpgradeTest.java:97)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:180)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.ignoreDenseCompoundTablesWithValueColumn(CompactStorage3to4UpgradeTest.java:100)
[junit-timeout]
[junit-timeout]
[junit-timeout] Testcase:
failOnCompactClusteredTablesWithValueOutColumn(org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest):
FAILED
[junit-timeout] should never run because we don't expect the node to start
[junit-timeout] junit.framework.AssertionFailedError: should never run because
we don't expect the node to start
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.lambda$failOnCompactClusteredTablesWithValueOutColumn$3(CompactStorage3to4UpgradeTest.java:112)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:180)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.failOnCompactClusteredTablesWithValueOutColumn(CompactStorage3to4UpgradeTest.java:113)
[junit-timeout]
[junit-timeout]
[junit-timeout] Testcase:
failOnCompactTablesWithNoClustering(org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest):
FAILED
[junit-timeout] should never run because we don't expect the node to start
[junit-timeout] junit.framework.AssertionFailedError: should never run because
we don't expect the node to start
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.lambda$failOnCompactTablesWithNoClustering$5(CompactStorage3to4UpgradeTest.java:130)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:180)
[junit-timeout] at
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest.failOnCompactTablesWithNoClustering(CompactStorage3to4UpgradeTest.java:131)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.distributed.upgrade.CompactStorage3to4UpgradeTest FAILED
BUILD FAILED
/Users/davidcapwell/src/github/apache/cassandra-trunk/build.xml:2035: The
following error occurred while executing this line:
/Users/davidcapwell/src/github/apache/cassandra-trunk/build.xml:1916: Some
test(s) failed.
Total time: 41 seconds
{code}
> Minimal 4.0 COMPACT STORAGE backport
> ------------------------------------
>
> Key: CASSANDRA-16217
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16217
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Normal
> Fix For: 4.0-beta4
>
>
> There are several behavioural changes related to compact storage, and these
> differences are larger than most of us have anticipated: we first thought
> there’ll be that “appearing column”, but there’s implicit nulls in
> clusterings thing, and row vs column deletion.
> Some of the recent issues on the subject are: CASSANDRA-16048, which allows
> to ignore these differences. The other one was trying to improve user
> experience of anyone still using compact storage: CASSANDRA-15811.
> Easily reproducible differernces are:
> (1) hidden columns show up, which breaks SELECT * queries
> (2) DELETE v and UPDATE v WITH TTL would result into row removals in
> non-dense compact tables (CASSANDRA-16069)
> (3) INSERT allows skipping clusterings, which are filled with nulls by
> default.
> Some of these are tricky to support, as 15811 has shown. Anyone on OSS side
> who might want to upgrade to 4.0 while still using compact storage might be
> affected by being forced into one of these behaviours.
> Possible solutions are to document these behaviours, or to bring back a
> minimal set of COMPACT STORAGE to keep supporting these.
> It looks like it is possible to leave some of the functionality related to
> DENSE flag and allow it to be present in 4.0, but only for these three (and
> potential related, however not direrclty visible) cases.
> [~e.dimitrova] since you were working on removal on compact storage, wanted
> to reassure that this is not a revert of your patch. On contrary: your patch
> was instrumental in identifying the right places.
> cc [~slebresne] [~aleksey] [~benedict] [~marcuse]
> |[patch|https://github.com/apache/cassandra/pull/785]|[ci|https://app.circleci.com/pipelines/github/ifesdjeen/cassandra?branch=13994-followup]|
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
