[
https://issues.apache.org/jira/browse/CASSANDRA-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233803#comment-17233803
]
David Capwell edited comment on CASSANDRA-16280 at 11/17/20, 6:23 PM:
----------------------------------------------------------------------
LGTM +1
I reverted your changes to src/java than ran the test added
{code}
testclasslist:
[echo] Number of test runners: 1
[mkdir] Created dir:
/Users/davidcapwell/src/github/apache/cassandra-oss-commit/build/test/cassandra
[mkdir] Created dir:
/Users/davidcapwell/src/github/apache/cassandra-oss-commit/build/test/output
[junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
[junit-timeout] Testsuite: org.apache.cassandra.tools.LoaderOptionsTest
[junit-timeout] Testsuite: org.apache.cassandra.tools.LoaderOptionsTest Tests
run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.761 sec
[junit-timeout]
[junit-timeout] Testcase:
testEncryptionSettings(org.apache.cassandra.tools.LoaderOptionsTest): Caused an
ERROR
[junit-timeout] EncryptionOptions cannot be changed after configuration applied
[junit-timeout] java.lang.IllegalStateException: EncryptionOptions cannot be
changed after configuration applied
[junit-timeout] at
org.apache.cassandra.config.EncryptionOptions.ensureConfigNotApplied(EncryptionOptions.java:162)
[junit-timeout] at
org.apache.cassandra.config.EncryptionOptions.applyConfig(EncryptionOptions.java:130)
[junit-timeout] at
org.apache.cassandra.tools.LoaderOptions$Builder.parseArgs(LoaderOptions.java:478)
[junit-timeout] at
org.apache.cassandra.tools.LoaderOptionsTest.testEncryptionSettings(LoaderOptionsTest.java:63)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test org.apache.cassandra.tools.LoaderOptionsTest FAILED
BUILD FAILED
/Users/davidcapwell/src/github/apache/cassandra-oss-commit/build.xml:2035: The
following error occurred while executing this line:
/Users/davidcapwell/src/github/apache/cassandra-oss-commit/build.xml:1916: Some
test(s) failed.
{code}
Tests are able to reproduce the issue!
was (Author: dcapwell):
LGTM +1
> SSTableLoader will fail if encryption parameters are used due to
> CASSANDRA-16144
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-16280
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16280
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
> Reporter: Alexander Dejanovski
> Assignee: Alexander Dejanovski
> Priority: Normal
> Fix For: 4.0-beta
>
>
> CASSANDRA-16144 recently introduced [repeated calls
> |https://github.com/apache/cassandra/compare/trunk...dcapwell:commit_remote_branch/CASSANDRA-16144-trunk-209E2350-3A50-457E-A466-F2661CD0D4D1#diff-b87acacbdc34464d327446f7a7e64718dbf843d70f5fbc9e5ddcd1bafca0f441R478]to
> _clientEncOptions.applyConfig()_ for each encryption parameter passed to the
> sstableloader command line.
> This consistently fails because _applyConfig()_ can be called only once due
> to the _ensureConfigNotApplied()_ check at the beginning of the method.
> This call is not necessary since the _with...()_ methods will invoke
> _applyConfig()_ each time:
> {code:java}
> public EncryptionOptions withTrustStore(String truststore)
> {
> return new EncryptionOptions(keystore, keystore_password, truststore,
> truststore_password, cipher_suites,
> protocol, algorithm, store_type,
> require_client_auth, require_endpoint_verification,
> enabled, optional).applyConfig();
> }
> {code}
> I'll build a patch for this with the appropriate unit test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
