[
https://issues.apache.org/jira/browse/CASSANDRA-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-16274:
----------------------------------------
Status: Changes Suggested (was: Review In Progress)
Overall LGTM, just a couple of minor things and a couple of nits from me:
* the {{Comparator}} in {{ReduceHelper::pickConsistent}} can be static
* typo in the comment for
{{RepairJobTest::testOptimizedCreateStandardSyncTasks}}, "{{addr1 or addr3}}"
should be "{{addr1 or addr2}}".
* shouldn't that same test verify that {{ReduceHelper::pickConsistent}} makes
the selections deterministic? So not use {{assertStreamRangeFromEither}}?
Nits:
* Alignment of params in {{ReduceHelper::pickConsistent}} is off
* the debug/progress output in {{OptimiseStreamsTest::randomTest}} is
meaningless, unless the initial insert should actually be much more than 10k
rows.
* {{RepairJobTest}} is the only place where we spell optimize with a z,
everywhere else uses an s, though this isn't new in this patch.
> Improve performance when calculating StreamTasks with optimised streaming
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-16274
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16274
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-beta4
>
>
> The way stream tasks are calculated currently is quite inefficient, improve
> that.
> Also, we currently try to distribute the streaming nodes evenly, this creates
> many more sstables than necessary - instead we should try to stream
> everything from a single peer, this should reduce the number of sstables
> created on the out-of-sync node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
