[ 
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243239#comment-17243239
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16205:
-------------------------------------------------

I trust your experienced committers' judgement on the solution design so I 
checked the implementation:
- CI run looks good
- I went through the refactoring to ensure there are no changes to the product. 
Looks good. I like how you rearranged the tests!
- Output, docs look good.
Except the very few nits you addressed, I didn't find any issues. +1
Thank you for all the hard work!

> Offline token allocation strategy generator tool
> ------------------------------------------------
>
>                 Key: CASSANDRA-16205
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Config, Local/Scripts
>            Reporter: Michael Semb Wever
>            Assignee: Michael Semb Wever
>            Priority: Normal
>
> A command line tool to generate tokens (using the 
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration 
> of {{initial_tokens}} in cassandra.yaml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to