[ https://issues.apache.org/jira/browse/CASSANDRA-16079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244710#comment-17244710 ]
Michael Semb Wever commented on CASSANDRA-16079: ------------------------------------------------ bq. Did you notice any speed improvements? All runs seem to be more or less the same when I look. The objective of this ticket is, from the description: "…optimize dtests in an attempt to gain back some of that runtime." If runs looks to have more or less the same performance, if they are including 13701, then that is a win. So… so long as we have made improvements that mostly offset the cost introduced by 13701 that this ticket I believe should be good to go. That is, this ticket is a blocker to 13701 getting merged into 4.0, and so is a blocker to 4.0. I don't have a problem with identified improvements to further improve dtest performance being spun out to further tickets (that don't block 4.0). What are your thoughts [~Bereng], [~aholmber], [~pauloricardomg]? For me the only remaining question here is if there are other dtests that should go through the runtime token allocation strategy rather than using the pre-generated tokens, that is using the cluster env variable: {{'CASSANDRA_TOKEN_PREGENERATION_DISABLED'}}. > Improve dtest runtime > --------------------- > > Key: CASSANDRA-16079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16079 > Project: Cassandra > Issue Type: Improvement > Components: CI > Reporter: Adam Holmberg > Assignee: Michael Semb Wever > Priority: Normal > Fix For: 4.0-beta > > Attachments: Screenshot 2020-09-19 at 12.32.21.png > > > A recent ticket, CASSANDRA-13701, changed the way dtests run, resulting in a > [30% increase in run > time|https://www.mail-archive.com/dev@cassandra.apache.org/msg15606.html]. > While that change was accepted, we wanted to spin out a ticket to optimize > dtests in an attempt to gain back some of that runtime. > At this time we don't have concrete improvements in mind, so the first order > of this ticket will be to analyze the state of things currently, and try to > ascertain some valuable optimizations. Once the problems are understood, we > will break down subtasks to divide the work. > Some areas to consider: > * cluster reuse > * C* startup optimizations > * Tests that should be ported to in-JVM dtest or even unit tests -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org