[ https://issues.apache.org/jira/browse/CASSANDRA-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268170#comment-17268170 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16318 at 1/19/21, 7:24 PM: --------------------------------------------------------------------------- The committer issue is solved. Patch committed [here|https://github.com/apache/cassandra/commit/661f1aab171dc3ef16075f69581e88ad4a133fae] with ninja fix of CHANGES.txt [here|https://github.com/apache/cassandra/commit/7214794e3f86b67d96371c78815c1ce03b3a5d6bhttps://github.com/apache/cassandra/commit/7214794e3f86b67d96371c78815c1ce03b3a5d6b] Thank you all! was (Author: e.dimitrova): The committer issues is solved. Patch committed [here|https://github.com/apache/cassandra/commit/661f1aab171dc3ef16075f69581e88ad4a133fae] with ninja fix of CHANGES.txt [here|https://github.com/apache/cassandra/commit/7214794e3f86b67d96371c78815c1ce03b3a5d6bhttps://github.com/apache/cassandra/commit/7214794e3f86b67d96371c78815c1ce03b3a5d6b] Thank you all! > Memtable heap size is severely underestimated > --------------------------------------------- > > Key: CASSANDRA-16318 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16318 > Project: Cassandra > Issue Type: Bug > Components: Local/Memtable > Reporter: Branimir Lambov > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.0-beta > > Attachments: image-2020-12-09-10-57-21-994.png, > image-2020-12-09-11-01-31-273.png > > > We seem to be estimating the size of the on-heap memtable metadata to be > around half of what it actually is. For example, during a [read benchmark > which writes 1 million single-long > rows|https://github.com/blambov/cassandra/blob/memtable-heap/test/microbench/org/apache/cassandra/test/microbench/instance/ReadTestSmallPartitions.java] > the memtable reports > {code} > 1000000 ops, 58.174MiB serialized bytes, 385.284MiB (19%) on heap, 0.000KiB > (0%) off-heap > {code} > while a heap dump taken at this point: > !image-2020-12-09-10-57-21-994.png! > lists an usage of about 666MB altogether. > Switching to {{offheap_objects}}, the reported numbers are > {code} > 1000000 ops, 58.174MiB serialized bytes, 233.650MiB (12%) on heap, 53.406MiB > (3%) off-heap > {code} > while actual heap usage: > !image-2020-12-09-11-01-31-273.png! > is about 442MB. > Looking at the code we definitely are not counting the > {{AtomicBTreePartition.Holder}}, {{EncodingStats}}, liveness and deletion > info objects associated with each partition, and most probably others. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org