[ https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280446#comment-17280446 ]
Michael Semb Wever edited comment on CASSANDRA-16428 at 2/8/21, 10:23 AM: -------------------------------------------------------------------------- [~eduard.tudenhoefner], i need an extra pair of eyes on this patch. I'm removing the docker {{ENV}} for JAVA_HOME, JAVA8_HOME, JAVA11_HOME. The .bashrc is already setting them, and as far as I can see the only place we use them is [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L27-L32] (and there the bashrc defined variables work). But these were only recently added as part of CASSANDRA-15835 [here|https://github.com/apache/cassandra-builds/commit/45dc010227d75bf05e34617729de5389e62f8f99#diff-9e34dd20086a6a0c4b9f9f238fabfffae47615da0416ef2929e61e3c1290005dR84-R86]. was (Author: michaelsembwever): [~eduard.tudenhoefner], i need an extra pair of eyes on this patch. I'm removing the docker {{ENV}} for JAVA_HOME, JAVA8_HOME, JAVA11_HOME. The .bashrc is already setting them, and as far as I can see the only place we use them is [here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L27-L32]. But these were only recently added as part of CASSANDRA-15835 [here|https://github.com/apache/cassandra-builds/commit/45dc010227d75bf05e34617729de5389e62f8f99#diff-9e34dd20086a6a0c4b9f9f238fabfffae47615da0416ef2929e61e3c1290005dR84-R86]. > Fix selections of JDKs in debian docker images on arm64 > ------------------------------------------------------- > > Key: CASSANDRA-16428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16428 > Project: Cassandra > Issue Type: Task > Components: Build, Packaging > Reporter: Michael Semb Wever > Assignee: Michael Semb Wever > Priority: Normal > > The debian docker > [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker] > used by the > [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh] > tries to set the jdk like > {code} > update-java-alternatives --set java-1.8.0-openjdk-amd64 > {code} > This won't work on arm64. > Suggestion is to replace it with the following: > {code} > update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 > | grep java-1.8) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org