[
https://issues.apache.org/jira/browse/CASSANDRA-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293725#comment-17293725
]
Alexandre Dutra commented on CASSANDRA-16444:
---------------------------------------------
Thank you [~blerer] and [~adelapena] for the thorough reviews.
{quote}I would change the cleanupData method
{quote}
Very good suggestion, done on both PRs.
{quote}I would also add
stores().forEach(ColumnFamilyStore::disableAutoCompaction); at the end of the
loadSchema() method
{quote}
Done on both PRs.
{quote}forcedFlushes are used but the tests do not disable the automatic flushes
{quote}
How would you do this? Should I play with {{memtable_flush_period_in_ms}} when
creating the tables?
{quote}Regarding testIndexMemtableSwitching problem in 3.11, it seems that the
test has been changed as part of CASSANDRA-15867 and I am not convinced that
this change was the correct one. If you roll back that change, do you still see
the same issue?
{quote}
I will try that next and let you know.
{quote}Regarding the timestamp fix, would it not make sense to use some thing
like rather than specifying the timestamp for each call to loadData?
{quote}
I actually have a slight preference for fixed timestamps as they produce
deterministic results. Using a counter means that you don't really control
which timestamps are being used. Besides, at least one test requires very
specific timestamps or it fails: {{testTruncate}}.
{quote}I think that perhaps we could clean here some of the many warnings in
SASIIndexTest.
{quote}
Absolutely, I cherry-picked your commit on both PRs and indeed the test class
looks much better.
At this point, I suggest that we re-run the multiplexer and see if at least
{{testTableRebuild}} and {{testIndexRebuild}} are fixed.
> Fix flaky test testMultiExpressionQueriesWhereRowSplitBetweenSSTables -
> org.apache.cassandra.index.sasi.SASIIndexTest
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16444
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16444
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: David Capwell
> Assignee: Alexandre Dutra
> Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/862/workflows/d2b10373-5bd1-4895-a738-1c28587cae62/jobs/5136
> {code}
> junit.framework.AssertionFailedError: []
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:589)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:468)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
