[ https://issues.apache.org/jira/browse/CASSANDRA-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049042#comment-13049042 ]
Sylvain Lebresne commented on CASSANDRA-2641: --------------------------------------------- bq. it overlaps quite a bit with StorageProxy.getRestrictedRanges: is there anything there that can be reused? getRestrictedRanges splits a range at different tokens. This patch is about merging overlapping range as part of normalize. Not sure I follow what could be reused here. And in any, I'm in favor of not refactoring anything that is not necessary for this patch. This is not worth it. > AbstractBounds.normalize should deal with overlapping ranges > ------------------------------------------------------------ > > Key: CASSANDRA-2641 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2641 > Project: Cassandra > Issue Type: Test > Components: Core > Reporter: Stu Hood > Assignee: Stu Hood > Priority: Minor > Fix For: 0.8.1 > > Attachments: 0001-Assert-non-overlapping-ranges-in-normalize.txt, > 0001-Make-normalize-deoverlap-ranges.patch, > 0002-Don-t-use-overlapping-ranges-in-tests.txt > > > Apparently no consumers have encountered it in production, but > AbstractBounds.normalize does not handle overlapping ranges. If given > overlapping ranges, the output will be sorted but still overlapping, for > which SSTableReader.getPositionsForRanges will choose ranges in an SSTable > that may overlap. > We should either add an assert in normalize(), or in getPositionsForRanges() > to ensure that this never bites us in production. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira