[
https://issues.apache.org/jira/browse/CASSANDRA-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301546#comment-17301546
]
Benjamin Lerer commented on CASSANDRA-16192:
--------------------------------------------
[~Bereng] The problem I see is that you cannot have reliable tests unless your
expectations are clear. Right now we do not seems to have a clear definition of
what some metric output should be and they will differ based on the strategy
you use. The current PR used a sub-class of {{SizeTieredCompactionStrategy}}
for testing the metrics, ignoring the fact that the metrics do not seems work
in the same way for the others strategies. For the tests to be reliable it
seems to me that the expected output should be well defined and that the test
should test the 3 main compaction strategies.
> Add more tests to cover compaction metrics
> ------------------------------------------
>
> Key: CASSANDRA-16192
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16192
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-rc
>
>
> Some compaction metrics do not seems to be tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
