[
https://issues.apache.org/jira/browse/CASSANDRA-16189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303460#comment-17303460
]
Andres de la Peña commented on CASSANDRA-16189:
-----------------------------------------------
>From a first round of review I have found that:
* The methods {{_start_two_node_cluster}}, {{_launch_nodetool_cmd}} and
{{_do_hinted_handoff}} seem just copied from {{hintedhandoff_test.py}}. The
method {{_drop_node2_and_do_hh}} seems a subset of {{_do_hinted_handoff}}. I
think we should try to reuse these methods instead of copying them.
* The test {{test_hintedhandoff_enabled}} is repeated in
{{hintedhandoff_test.py}} and {{hintedhandoff_metrics_test.py}}.
* If I'm understanding it, the new test {{test_hintedhandoff_metrics}}
collects the hh metrics and does some verifications about general invariants of
the metrics, like that the rate unit is always events per second, or that
{{HintsTimedOut}} is lesser or equals that {{HintsFailed}}, or that the total
number of hints is the addition on {{HintsSucceeded}} and {{HintsFailed}}.
However, the collected metrics don't contain any failure, so I think we aren't
really verifying that hint failures, timeouts, etc. are tracked unless we
produce one of these failures.
> Add tests for the Hint service metrics
> --------------------------------------
>
> Key: CASSANDRA-16189
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16189
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Benjamin Lerer
> Assignee: Mohamed Zafraan
> Priority: Normal
> Fix For: 4.0-rc
>
> Attachments: 0001-added-hints-metrics-test.patch
>
>
> There are currently no tests for the hint metrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
