[ https://issues.apache.org/jira/browse/CASSANDRA-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322404#comment-17322404 ]
David Capwell commented on CASSANDRA-16561: ------------------------------------------- I think I went the route of adding token/host to the empty case in CASSANDRA-16213 on startup but there were concerns about it (I think it was concerns about potential unknown side effects), so we limited populating this data only when shadow round is performed to limit the possible side effects that could happen; this has the side effect that new nodes (which join via host replacement) sees the host_id and token in the empty state in gossip (as we were forced to copy those values from the shadow round into normal gossip state), but the other nodes don't (including bootstrapped nodes). If I understand your point, the argument is to also provide this information to bootstrapping nodes (which we do now via shadow round) *and store the results*? > Gossip is not populated with tokens/host_ids > -------------------------------------------- > > Key: CASSANDRA-16561 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16561 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip > Reporter: Brandon Williams > Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > Originally when we began persisting host information such a tokens/host_id, > we would populate gossip with this information. At some point we began only > populating TokenMetadata, which gives us most of the same benefit, but in a > full ring restart where the gossip ether is empty, it populates useless info > such as : > {quote} > /10.101.32.212 > generation:0 > heartbeat:0 > TOKENS: not present > {quote} > which is the minimum required for a state to exist. Instead we should keep > gossip in sync with TMD when populating this information like we used to do. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org