[ https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Fleming updated CASSANDRA-16623: ------------------------------------- Description: Newcomers to cassandra-dtest that look through README.md will see that the run_dtests.py script is the quickest way to get started running tests. Unfortunately, the script has a number of problems and I'm not sure it ever work properly after the move to the pytest framework. h2. Process stdout/stderr buffering Firstly, when I execute run_dtests.py I don't see any output after $ ./run_dtests.py --dtest-tests paging_test.py ============================= test session starts ============================== This looks likely to be because of the buffering that pytest does internally for stdout and stderr and because of the way that it's executed by run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following line for most of the execution because there's no data available in the pipe for stderr: stderr_output = sp.stderr.readline() See also pytest-dev/pytest#1886 h2. --pytest-options doesn't work Secondly, the options specified in --pytest-options aren't actually passed through to pytest. h2. Most devs run pytest directly When I spoke to [~edimitrova] it seemed like most developers just run the tests directly with pytest which would explain why run_dtests.py has bitrotted. was: Newcomers to cassandra-dtest that look through README.md will see that the run_dtests.py script is the quickest way to get started running tests. Unfortunately, the script has a number of problems and I'm not sure it ever work properly after the move to the pytest framework. h2. Process stdout/stderr buffering Firstly, when I execute run_dtests.py I don't see any output after $ ./run_dtests.py --dtest-tests paging_test.py ============================= test session starts ============================== This looks likely to be because of the buffering that pytest does internally for stdout and stderr and because of the way that it's executed by run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following line for most of the execution because there's no data available in the pipe for stderr: stderr_output = sp.stderr.readline() See also pytest-dev/pytest#1886 h2. --pytest-options doesn't work Secondly, the options specified in --pytest-options aren't actually passed through to pytest. h2. Most devs run pytest directly When I spoke to @ekaterinadimitrova2 it seemed like most developers just run the tests directly with pytest which would explain why run_dtests.py has bitrotted. > Remove references to run_dtests from README > ------------------------------------------- > > Key: CASSANDRA-16623 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16623 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python > Reporter: Matt Fleming > Priority: Normal > > Newcomers to cassandra-dtest that look through README.md will see that the > run_dtests.py script is the quickest way to get started running tests. > Unfortunately, the script has a number of problems and I'm not sure it ever > work properly after the move to the pytest framework. > h2. Process stdout/stderr buffering > Firstly, when I execute run_dtests.py I don't see any output after > $ ./run_dtests.py --dtest-tests paging_test.py > ============================= test session starts > ============================== > This looks likely to be because of the buffering that pytest does internally > for stdout and stderr and because of the way that it's executed by > run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following > line for most of the execution because there's no data available in the pipe > for stderr: > stderr_output = sp.stderr.readline() > See also pytest-dev/pytest#1886 > h2. --pytest-options doesn't work > Secondly, the options specified in --pytest-options aren't actually passed > through to pytest. > h2. Most devs run pytest directly > When I spoke to [~edimitrova] it seemed like most developers just run the > tests directly with pytest which would explain why run_dtests.py has > bitrotted. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org