[
https://issues.apache.org/jira/browse/CASSANDRA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335087#comment-17335087
]
Ekaterina Dimitrova commented on CASSANDRA-16613:
-------------------------------------------------
Hey Sam,
I applied the changes you suggested plus had a few more findings. Latest work
can be found [here|https://github.com/ekaterinadimitrova2/cassandra/pull/109]
Now two other questions popped up on my mind:
1) The in-jvm tests were using V4
[here|https://github.com/ekaterinadimitrova2/cassandra/pull/109/commits/d99f056cb8189c157dd76110542817e0981397dd#diff-34798e91d93d9e49dbb896c4e25f7f803ce9c9229a6397961cd5ff6d7b902c82L110].
I changed it to testing with the CURRENT version, not sure that this is
enough. WDYT?
2) I am going also to inspect the Python DTests tomorrow as it seems at least
in
[dtest.py|https://github.com/apache/cassandra-dtest/blob/trunk/dtest.py#L279]
we don't list the new beta version 6.
Java 8 CI run
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/780/workflows/86279a12-e844-4af0-a6a3-79a2cdb45597]
Java 11 CI run
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/780/workflows/096f6d5e-ce0a-4ec7-98df-6a76d729f19b]
I ran the shorter tests locally successfully.
CircleCI is still running
> ProtocolVersion.V4 is still used in places in the code
> ------------------------------------------------------
>
> Key: CASSANDRA-16613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16613
> Project: Cassandra
> Issue Type: Bug
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-rc
>
>
> While working on CASSANDRA-16567, [~adelapena] observed that
> _ProtocolVersion.V4_ is used in _ViewTest_.
> I decided to do a quick grep and observed a list of places where we still
> refer to V4 and it seems at least in many of the tests that was left not
> intentionally.
> This ticket is to verify the usage of _ProtocolVersion.V4_ in the codebase
> and bump it to V5 or default version, similar to what was done in
> CASSANDRA-16567, wherever there is a need.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
